rspec/rules/S134/csharp/rule.adoc

90 lines
2.0 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
Nested control flow statements ``++if++``, ``++switch++``, ``++for++``, ``++foreach++``, ``++while++``, ``++do++``, and ``++try++`` are often key ingredients in creating
what's known as "Spaghetti code". This code smell can make your program difficult to understand and maintain.
2021-02-02 15:02:10 +01:00
When numerous control structures are placed inside one another, the code becomes a tangled, complex web.
This significantly reduces the code's readability and maintainability, and it also complicates the testing process.
2020-06-30 12:47:33 +02:00
== How to fix it
2020-06-30 12:47:33 +02:00
=== Code examples
The following example demonstrates the behavior of the rule with the default threshold of 3 levels of nesting
and one of the potential ways to fix the code smell by introducing guard clauses:
==== Noncompliant code example
[source,csharp,diff-id=1,diff-type=noncompliant]
2020-06-30 12:47:33 +02:00
----
if (condition1) // Compliant - depth = 1
{
2020-06-30 12:47:33 +02:00
/* ... */
if (condition2) // Compliant - depth = 2
{
2020-06-30 12:47:33 +02:00
/* ... */
for (int i = 0; i < 10; i++) // Compliant - depth = 3
{
2020-06-30 12:47:33 +02:00
/* ... */
if (condition4) // Noncompliant - depth = 4, which exceeds the limit
2020-06-30 12:47:33 +02:00
{
if (condition5) // Depth = 5, exceeding the limit, but issues are only reported on depth = 4
2020-06-30 12:47:33 +02:00
{
/* ... */
}
return;
}
}
}
}
----
==== Compliant solution
[source,csharp,diff-id=1,diff-type=compliant]
----
if (!condition1)
{
return;
}
/* ... */
if (!condition2)
{
return;
}
for (int i = 0; i < 10; i++)
{
/* ... */
if (condition4)
{
if (condition5)
{
/* ... */
}
return;
}
}
----
include::../resources.adoc[]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../parameters.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]