rspec/rules/S4828/php/rule.adoc

39 lines
634 B
Plaintext
Raw Normal View History

2020-06-30 12:49:37 +02:00
include::../description.adoc[]
include::../ask-yourself.adoc[]
include::../recommended.adoc[]
== Sensitive Code Example
[source,php]
2020-06-30 12:49:37 +02:00
----
$targetPid = (int)$_GET["pid"];
posix_kill($targetPid, 9); // Sensitive
----
== Compliant Solution
[source,php]
----
$targetPid = (int)$_GET["pid"];
// Validate the untrusted PID,
// With a pre-approved list or authorization checks
if (isValidPid($targetPid)) {
posix_kill($targetPid, 9);
}
2020-06-30 12:49:37 +02:00
----
include::../see.adoc[]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
endif::env-github,rspecator-view[]