rspec/rules/S5119/abap/rule.adoc

== Why is this an issue?

Modifying SAP standard tables via an Open SQL statement can result in data corruption and unexpected behavior. This is because a direct modification bypasses all validation mechanisms.

Instead, the use of standard functions or SAP Business Add-Ins (BAdIs) is recommended.


This rule raises an issue on Open SQL statements ``++INSERT++``, ``++UPDATE++``, ``++MODIFY++``, or ``++SELECT ... FOR UPDATE++`` which target an SAP table, i.e. a table with a name starting with a character between "A" and "X", case insensitive.


=== Noncompliant code example

[source,abap]
----
SELECT my_col FROM my_system_table WHERE my_id = 123 FOR UPDATE. " Noncompliant

SELECT my_col FROM z_custom_table WHERE my_id = 123 FOR UPDATE. " Ignored; modifies a custom table
----


ifdef::env-github,rspecator-view[]

'''
== Implementation Specification
(visible only on this page)

=== Message

Replace this Open SQL statement with a standard function call or an SAP BAdI


=== Highlighting

The table name


'''
== Comments And Links
(visible only on this page)

=== on 2 Jan 2019, 14:56:43 Ann Campbell wrote:
\[~nicolas.harraudeau] it wasn't clear to me until I got to the code sample that the targeted characters are case-insensitive. 


Also, is the second line in the code sample intended to be the Compliant solution, or just an example of something that's ignored by the rule? If the former, it should be moved into a separate, "Compliant Solution" sample, where no "compliant" comment is needed because everything in it is compliant by definition. (And really, even in the Noncompliant example I wouldn't use a "compliant" comment.)

=== on 4 Jan 2019, 10:00:23 Nicolas Harraudeau wrote:
\[~ann.campbell.2] Thanks for the review. The second example is just something ignored by the rule. I changed the "Compliant" comment into something more explicit. Let me know if it is still not clear.

=== on 7 Jan 2019, 08:55:39 Alexandre Gigleux wrote:
\[~nicolas.harraudeau] 

* I renamed "OpenSQL" and "OpenSql" into "Open SQL" because it looks to be the format used by SAP: \https://help.sap.com/doc/saphelp_nw70/7.0.31/en-US/fc/eb3969358411d1829f0000e829fbfe/content.htm?no_cache=true
* Could you add a link here, as a comment, to SAP Badis, because I can't find what it is and I would like to learn more about it? Thx

endif::env-github,rspecator-view[]