rspec/rules/S1151/plsql/rule.adoc

61 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
The ``++CASE++`` statement should be used only to clearly define some new branches in the control flow. As soon as a ``++WHEN++`` clause contains too many statements this highly decreases the readability of the overall control flow statement. In such case, the content of ``++WHEN++`` clause should be extracted in a dedicated function.
2020-06-30 12:47:33 +02:00
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:47:33 +02:00
----
CASE my_variable
WHEN 0 THEN -- 6 lines till next WHEN
procedure1;
procedure2;
procedure3;
procedure4;
procedure5;
WHEN 1 THEN
-- ...
END CASE;
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:47:33 +02:00
----
DECLARE
PROCEDURE do_something AS
BEGIN
procedure1;
procedure2;
procedure3;
procedure4;
procedure5;
END;
BEGIN
CASE my_variable
WHEN 0 THEN
do_something;
WHEN 1 THEN
-- ...
END CASE;
END;
/
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../parameters.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]