rspec/rules/S1244/swift/rule.adoc

54 lines
1.5 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Floating point math is imprecise because of the challenges of storing such values in a binary representation. Even worse, floating point math is not associative; push a ``++Float++`` or a ``++Double++`` through a series of simple mathematical operations and the answer will be different based on the order of those operation because of the rounding that takes place at each step.
2020-06-30 12:47:33 +02:00
2021-02-02 15:02:10 +01:00
2020-06-30 12:47:33 +02:00
Even simple floating point assignments are not simple:
2020-06-30 12:47:33 +02:00
----
var f: Float = 0.1 // 0.1000000014901161193847656
var d: Double = 0.1 // 0.1000000000000000055511151
----
2021-01-27 13:42:22 +01:00
Therefore, the use of the equality (``++==++``) and inequality (``++!=++``) operators on ``++Float++`` or ``++Double++`` values is almost always an error.
2020-06-30 12:47:33 +02:00
2021-02-02 15:02:10 +01:00
2020-06-30 12:47:33 +02:00
This rule checks for the use of direct and indirect equality/inequailty tests on floats and doubles.
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,swift]
2020-06-30 12:47:33 +02:00
----
var myNumber: Float = 0.3 + 0.6
if myNumber == 0.9 { // Noncompliant. Because of floating point imprecision, this will be false
// ...
}
if myNumber <= 0.9 && myNumber >= 0.9 { // Noncompliant indirect equality test
// ...
}
if myNumber < 0.9 || myNumber > 0.9 { // Noncompliant indirect inequality test
// ...
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Equality tests should not be made with floating point values.
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]