rspec/rules/S3981/kotlin/rule.adoc

37 lines
895 B
Plaintext
Raw Normal View History

== Why is this an issue?
2023-05-29 18:37:58 +02:00
The size of a collection or an array is always greater than or equal to zero. Testing it doesn't make sense, since the result is always `true`.
[source,kotlin]
----
2023-05-29 18:37:58 +02:00
if (myList.size >= 0) {...} // Noncompliant: always true
2023-05-29 18:37:58 +02:00
boolean result = myArray.size >= 0; // Noncompliant: always true
----
2023-05-29 18:37:58 +02:00
Similarly testing that it is less than zero will always return `false`.
[source,kotlin]
----
2023-05-29 18:37:58 +02:00
if (myList.size < 0) {...} // Noncompliant: always false
----
2023-05-29 18:37:58 +02:00
Fix the code to properly check for emptiness if it was the intent, or remove the redundant code to keep the current behavior.
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]