2023-05-03 11:06:20 +02:00
== Why is this an issue?
2021-04-28 16:49:39 +02:00
Changing an inherited member to ``++private++`` will not prevent access to the base class implementation.
This rule raises an issue when a ``++private++`` method in an unsealed type has a signature that is identical to a ``++public++`` method declared in a base type.
2021-04-28 18:08:03 +02:00
2023-05-03 11:06:20 +02:00
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,csharp]
2021-04-28 16:49:39 +02:00
----
using System;
namespace MyLibrary
{
public class Foo
{
public void SomeMethod(int count) { }
}
public class Bar:Foo
{
private void SomeMethod(int count) { } // Noncompliant
}
}
----
2021-04-28 18:08:03 +02:00
2023-05-03 11:06:20 +02:00
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,csharp]
2021-04-28 16:49:39 +02:00
----
using System;
namespace MyLibrary
{
public class Foo
{
public void SomeMethod(int count) { }
}
public sealed class Bar : Foo
{
private void SomeMethod(int count) { }
}
}
----
2021-04-28 18:08:03 +02:00
2021-06-02 20:44:38 +02:00
2021-06-03 09:05:38 +02:00
ifdef::env-github,rspecator-view[]
2021-09-20 15:38:42 +02:00
'''
== Implementation Specification
(visible only on this page)
2023-05-25 14:18:12 +02:00
=== Message
This member hides '{0}'. Make it non-private or seal the class.
=== Highlighting
member declaration
2021-09-20 15:38:42 +02:00
2021-06-08 15:52:13 +02:00
'''
2021-06-02 20:44:38 +02:00
== Comments And Links
(visible only on this page)
2023-05-25 14:18:12 +02:00
=== relates to: S3434
=== on 22 May 2017, 13:19:56 Ann Campbell wrote:
\[~jeanchristophe.collet] RSPEC-2387 is already covered by C#. On the face of it, these two rules overlap nearly completely.
=== on 22 May 2017, 13:59:50 Jean-Christophe Collet wrote:
\[~ann.campbell.2] RSPEC-2387 only covers fields, this rule covers only methods without an override.
=== on 22 May 2017, 15:10:29 Ann Campbell wrote:
Okay, then RSPEC-3434 is the related RSpec, altho it's scope is different. I've added it as 'related'
2021-06-03 09:05:38 +02:00
endif::env-github,rspecator-view[]