rspec/rules/S1444/java/rule.adoc

33 lines
893 B
Plaintext
Raw Normal View History

2021-01-27 13:42:22 +01:00
There is no good reason to declare a field "public" and "static" without also declaring it "final". Most of the time this is a kludge to share a state among several objects. But with this approach, any object can do whatever it wants with the shared state, such as setting it to ``++null++``.
2020-06-30 12:47:33 +02:00
== Noncompliant Code Example
----
public class Greeter {
public static Foo foo = new Foo();
...
}
----
== Compliant Solution
----
public class Greeter {
public static final Foo FOO = new Foo();
...
}
----
== See
* http://cwe.mitre.org/data/definitions/500.html[MITRE, CWE-500] - Public Static Field Not Marked Final
* https://wiki.sei.cmu.edu/confluence/x/WjdGBQ[CERT OBJ10-J.] - Do not use public static nonfinal fields
ifdef::env-github,rspecator-view[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]