rspec/rules/S1151/rpg/rule.adoc

64 lines
1.7 KiB
Plaintext
Raw Normal View History

2021-01-27 13:42:22 +01:00
The ``++SELECT++`` statement should be used only to clearly define some new branches in the control flow. As soon as a ``++WHEN++`` clause contains too many statements this highly decreases the readability of the overall control flow statement. In such case, the content of ``++WHEN++`` clause should be extracted in a dedicated subroutine.
2020-06-30 12:47:33 +02:00
== Noncompliant Code Example
----
C SELECT
C WHEN X=1
C MOVE A B
C MOVE C D
C MOVE E F
C MOVE J K
C MOVE L M
C WHEN X=2
C ....
C ENDSL
/free
select;
when X=1;
B = A;
D = C;
F = E;
K = J;
M = L;
when X=2;
...
endsl;
/end-free
----
== Compliant Solution
----
C SELECT
C WHEN X=1
C EXSR SR011
C WHEN X=2
C ....
C ENDSL
C ...
C SR011 BEGSR
C MOVE A B
C MOVE C D
C MOVE E F
C MOVE J K
C MOVE L M
C ENDSR
/free
select;
when X=1;
exsr SR011;
when X=2;
...
endsl;
/end-free
----
ifdef::env-github,rspecator-view[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]