rspec/rules/S6096/java/rule.adoc

include::../description.adoc[]

== Noncompliant Code Example

----
  public static List<String> zipSlipNoncompliant(ZipFile zipFile) throws IOException {
    Enumeration<? extends ZipEntry> entries = zipFile.entries();
    List<String> filesContent = new ArrayList<>();

    while (entries.hasMoreElements()) {
      ZipEntry entry = entries.nextElement();
      File file = new File(entry.getName());
      String content = FileUtils.readFileToString(file, StandardCharsets.UTF_8); // Noncompliant
      filesContent.add(content);
    }

    return filesContent;
  }
----

== Compliant Solution

----
  public static List<String> zipSlipCompliant(ZipFile zipFile, String targetDirectory) throws IOException {
    Enumeration<? extends ZipEntry> entries = zipFile.entries();
    List<String> filesContent = new ArrayList<>();

    while (entries.hasMoreElements()) {
      ZipEntry entry = entries.nextElement();
      File file = new File(entry.getName());
      String canonicalDestinationPath = file.getCanonicalPath();

      if (!canonicalDestinationPath.startsWith(targetDirectory)) {
        throw new IOException("Entry is outside of the target directory");
      }

      String content = FileUtils.readFileToString(file, StandardCharsets.UTF_8); // OK
      filesContent.add(content);
    }

    return filesContent;
  }
----

include::../see.adoc[]