2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2021-04-28 16:49:39 +02:00
|
|
|
Call stacks containing lot of ``++PERFORM++`` statements is a key ingredient for making what's known as "Spaghetti code".
|
|
|
|
|
|
|
|
Such code is hard to read, refactor and therefore maintain.
|
|
|
|
|
|
|
|
|
|
|
|
This rule supports both sections and paragraphs.
|
|
|
|
|
2021-04-28 18:08:03 +02:00
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Noncompliant code example
|
2021-04-28 16:49:39 +02:00
|
|
|
|
|
|
|
With a threshold of 3:
|
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,cobol]
|
2021-04-28 16:49:39 +02:00
|
|
|
----
|
|
|
|
PERFORM FIRST.
|
|
|
|
|
|
|
|
FIRST.
|
|
|
|
PERFORM SECOND.
|
|
|
|
|
|
|
|
SECOND.
|
|
|
|
PERFORM THIRD.
|
|
|
|
|
|
|
|
THIRD.
|
|
|
|
PERFORM FOURTH. *> Noncompliant
|
|
|
|
|
|
|
|
FOURTH.
|
|
|
|
DISPLAY something.
|
|
|
|
----
|
2021-04-28 18:08:03 +02:00
|
|
|
|
|
|
|
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
2023-05-25 14:18:12 +02:00
|
|
|
=== Message
|
|
|
|
|
|
|
|
This module can trigger long chain of up to 6 PERFORMs, for example using the ones at line: 123 -> 23 -> 54 -> ...
|
|
|
|
|
|
|
|
|
|
|
|
=== Parameters
|
|
|
|
|
|
|
|
.max
|
|
|
|
****
|
|
|
|
|
|
|
|
----
|
|
|
|
5
|
|
|
|
----
|
|
|
|
|
|
|
|
Maximum allowed call stack
|
|
|
|
****
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
2023-05-25 14:18:12 +02:00
|
|
|
=== is related to: S1684
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|