rspec/rules/S3055/csharp/rule.adoc

23 lines
1001 B
Plaintext
Raw Normal View History

2021-01-27 13:42:22 +01:00
Synchronization can be expensive in terms of time when multiple threads need to pass through the same bottleneck (method with ``++\[MethodImpl(MethodImplOptions.Synchronized)\]++``).
2020-06-30 12:48:39 +02:00
2021-01-27 13:42:22 +01:00
If you have a piece of code calling a method with ``++\[MethodImpl(MethodImplOptions.Synchronized)\]++`` attribute once, then it only has to wait its turn to pass through the bottleneck once. But call it in a loop, and your code has to get back in line for the bottleneck over and over.
2020-06-30 12:48:39 +02:00
Instead, it would be better to get into the bottleneck, and then do the looping. I.e. consider refactoring the code to perform the loop inside the method.
2021-01-27 13:42:22 +01:00
This rule raises an issue when a method with ``++\[MethodImpl(MethodImplOptions.Synchronized)\]++`` is called in a loop.
2020-06-30 12:48:39 +02:00
== Noncompliant Code Example
----
public void doSomething(int max) {
for (int i = 0; i < max; i++) {
doSynchronized(i); // Noncompliant
}
}
[MethodImpl(MethodImplOptions.Synchronized)]
public void doSynchronized(int val) {
// ...
}
----