rspec/rules/S1821/php/rule.adoc

56 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Nested ``++switch++`` structures are difficult to understand because you can easily confuse the cases of an inner ``++switch++`` as belonging to an outer statement. Therefore nested ``++switch++`` statements should be avoided.
2020-06-30 12:47:33 +02:00
2021-02-02 15:02:10 +01:00
2021-01-27 13:42:22 +01:00
Specifically, you should structure your code to avoid the need for nested ``++switch++`` statements, but if you cannot, then consider moving the inner ``++switch++`` to another function.
2020-06-30 12:47:33 +02:00
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:47:33 +02:00
----
switch($a) {
case "foo":
switch($b) { // Noncompliant
case "bar":
doSomething();
break;
}
break;
}
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:47:33 +02:00
----
function handleFoo($foo) {
switch($foo) {
case "bar":
doSomething();
break;
}
}
switch($a) {
case "foo":
handleFoo($b);
break;
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]