rspec/rules/S5756/python/rule.adoc

83 lines
1.6 KiB
Plaintext
Raw Normal View History

2023-06-30 09:13:07 +02:00
This rule raises an issue when a call is made to a non-callable object.
== Why is this an issue?
2021-04-28 16:49:39 +02:00
:link-with-uscores1: https://docs.python.org/3/reference/datamodel.html#object.__call__
2023-06-30 09:13:07 +02:00
In order to be callable, a Python class should implement the {link-with-uscores1}[``++__call__++``] method. Thanks to this method, an instance of this class will be callable as a function.
2021-04-28 16:49:39 +02:00
2023-06-30 09:13:07 +02:00
However, when making a call to a non-callable object, a `TypeError` will be raised.
2021-04-28 16:49:39 +02:00
2023-06-30 09:13:07 +02:00
In order to fix this issue, make sure that the object you are trying to call has a `++__call__++` method.
2021-04-28 16:49:39 +02:00
2023-06-30 09:13:07 +02:00
=== Code examples
2023-06-30 09:13:07 +02:00
==== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,python]
2021-04-28 16:49:39 +02:00
----
class MyClass:
pass
myvar = MyClass()
myvar() # Noncompliant
none_var = None
none_var() # Noncompliant
----
2023-06-30 09:13:07 +02:00
==== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,python]
2021-04-28 16:49:39 +02:00
----
class MyClass:
def __call__(self):
print("called")
myvar = MyClass()
myvar()
----
2021-04-28 16:49:39 +02:00
:link-with-uscores1: https://docs.python.org/3/reference/datamodel.html#object.__call__
== Resources
2021-04-28 16:49:39 +02:00
2023-06-30 09:13:07 +02:00
=== Documentation
2021-04-28 16:49:39 +02:00
* {link-with-uscores1}[Python documentation - ++__call__++ method]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Fix this call; XX is not callable.
=== Highlighting
Primary: The name before the opening parenthesis
* Secondary 1 (if the call is made on a variable)
** location: The last value assigned.
** message: "Assigned value."
* Secondary 2
** location: The class definition
** message: "Definition."
'''
== Comments And Links
(visible only on this page)
=== relates to: S2873
endif::env-github,rspecator-view[]