2021-06-03 09:05:38 +02:00
|
|
|
=== on 12 May 2015, 14:52:51 David Gageot wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
lgtm
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
=== on 20 May 2015, 15:08:39 Nicolas Peru wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
Ok.
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
=== on 21 Aug 2015, 09:21:47 Michael Gumowski wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
WDYT about changes [~duarte.meneses]?
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
=== on 21 Aug 2015, 09:29:58 Duarte Meneses wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
Looks good.
|
|
|
|
|
|
|
|
|
|
Only suggestion I have is to put the timeout in the solution longer (2/3s?), otherwise it wouldn't fix the problem of dependency on the environment.
|
|
|
|
|
|
|
|
|
|
With awaitility we can use larger timeouts but still proceed quickly as soon as the polling conditions is satisfied.
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
=== on 21 Aug 2015, 09:35:55 Michael Gumowski wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
Ok, updated. Thanks for your feedback! Feels free to modify it directly next time!
|
|
|
|
|
|
