2023-05-03 11:06:20 +02:00
== Why is this an issue?
2021-04-28 18:08:03 +02:00
Overriding the ``++Object.finalize()++`` method must be done with caution to dispose some system resources.
Calling the ``++super.finalize()++`` at the end of this method implementation is highly recommended in case parent implementations must also dispose some system resources.
2023-05-03 11:06:20 +02:00
=== Noncompliant code example
2021-04-28 18:08:03 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 18:08:03 +02:00
----
protected void finalize() { // Noncompliant; no call to super.finalize();
releaseSomeResources();
}
protected void finalize() {
super.finalize(); // Noncompliant; this call should come last
releaseSomeResources();
}
----
2023-05-03 11:06:20 +02:00
=== Compliant solution
2021-04-28 18:08:03 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 18:08:03 +02:00
----
protected void finalize() {
releaseSomeResources();
super.finalize();
}
----
2023-05-03 11:06:20 +02:00
== Resources
2021-04-28 18:08:03 +02:00
2022-04-07 08:53:59 -05:00
* https://cwe.mitre.org/data/definitions/568[MITRE, CWE-568] - finalize() Method Without super.finalize()
2021-04-28 18:08:03 +02:00
* https://wiki.sei.cmu.edu/confluence/x/4jZGBQ[CERT, MET12-J.] - Do not use finalizers
2021-06-02 20:44:38 +02:00
2021-06-03 09:05:38 +02:00
ifdef::env-github,rspecator-view[]
2021-09-20 15:38:42 +02:00
'''
== Implementation Specification
(visible only on this page)
2023-05-25 14:18:12 +02:00
=== Message
Add a call to super.finalize() at the end of this Object.finalize() implementation.
Move this super.finalize() call to the end of this Object.finalize() implementation.
2021-09-20 15:38:42 +02:00
2021-06-08 15:52:13 +02:00
'''
2021-06-02 20:44:38 +02:00
== Comments And Links
(visible only on this page)
2023-05-25 14:18:12 +02:00
=== is related to: S1115
=== on 4 Jul 2013, 12:09:44 Freddy Mallet wrote:
Is implemented by \http://jira.codehaus.org/browse/SONARJAVA-197
2021-06-03 09:05:38 +02:00
endif::env-github,rspecator-view[]