rspec/rules/S1621/rpg/rule.adoc

== Why is this an issue?

Indicators should not be used on "IF" statements because they foster poor logic flow and result in code that is difficult to read and maintain.


=== Noncompliant code example

[source,rpg]
----
C   99FLD1          IFEQ      FLD2
----


=== Compliant solution

[source,rpg]
----
C     FLD1          IFEQ      FLD2
C     *IN99         ANDEQ     *ON
----

ifdef::env-github,rspecator-view[]

'''
== Implementation Specification
(visible only on this page)

=== Message

Move this indicator into an additional clause in the "IF" statement


endif::env-github,rspecator-view[]
migrate rule descriptions to new education format 2023-05-03 11:06:20 +02:00			`== Why is this an issue?`

Restructure one-lang rspecs 2021-04-28 16:49:39 +02:00			`Indicators should not be used on "IF" statements because they foster poor logic flow and result in code that is difficult to read and maintain.`

Fix the missing default metadata fields 2021-04-28 18:08:03 +02:00
migrate rule descriptions to new education format 2023-05-03 11:06:20 +02:00			`=== Noncompliant code example`
Restructure one-lang rspecs 2021-04-28 16:49:39 +02:00
RULEAPI-661: Add syntax coloring 2022-02-04 17:28:24 +01:00			`[source,rpg]`
Restructure one-lang rspecs 2021-04-28 16:49:39 +02:00			`----`
			`C 99FLD1 IFEQ FLD2`
			`----`

Fix the missing default metadata fields 2021-04-28 18:08:03 +02:00
migrate rule descriptions to new education format 2023-05-03 11:06:20 +02:00			`=== Compliant solution`
Restructure one-lang rspecs 2021-04-28 16:49:39 +02:00
RULEAPI-661: Add syntax coloring 2022-02-04 17:28:24 +01:00			`[source,rpg]`
Restructure one-lang rspecs 2021-04-28 16:49:39 +02:00			`----`
			`C FLD1 IFEQ FLD2`
			`C IN99 ANDEQ ON`
			`----`
Fix the missing default metadata fields 2021-04-28 18:08:03 +02:00
RULEAPI-666: Migrate the "List of parameters", "Highlighting" and "Message" fields from jira RSPEC (#346) 2021-09-20 15:38:42 +02:00			`ifdef::env-github,rspecator-view[]`

			`'''`
			`== Implementation Specification`
			`(visible only on this page)`

Inline adoc when include has no additional value (#1940) Inline adoc files when they are included exactly once. Also fix language tags because this inlining gives us better information on what language the code is written in. 2023-05-25 14:18:12 +02:00			`=== Message`

			`Move this indicator into an additional clause in the "IF" statement`

RULEAPI-666: Migrate the "List of parameters", "Highlighting" and "Message" fields from jira RSPEC (#346) 2021-09-20 15:38:42 +02:00
			`endif::env-github,rspecator-view[]`