rspec/rules/S109/abap/rule.adoc

include::../description.adoc[]

include::../how-to-fix-it.adoc[]

=== Code examples

==== Noncompliant code example

[source,abap,diff-id=1,diff-type=noncompliant]
----
IF sy-subrc EQ 42.      " Noncompliant - 5 is a magic number
  screen-request = 'OK'.
ENDIF.
----

==== Compliant solution

[source,abap,diff-id=1,diff-type=compliant]
----
answer = 42.
IF sy-subrc EQ answer.  " Compliant
  screen-request = 'OK'.
ENDIF.
----

ifdef::env-github,rspecator-view[]

'''
== Implementation Specification
(visible only on this page)

include::../message.adoc[]

'''
== Comments And Links
(visible only on this page)

include::../comments-and-links.adoc[]

endif::env-github,rspecator-view[]
Add rules 100-128 (#10) 2020-06-30 10:16:44 +02:00			`include::../description.adoc[]`

Modify S109: Migrate To LayC (#3235) ## Review A dedicated reviewer checked the rule description successfully for: - [x] logical errors and incorrect information - [x] information gaps and missing content - [x] text style and tone - [x] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) 2023-10-11 13:58:56 +02:00			`include::../how-to-fix-it.adoc[]`

			`=== Code examples`

			`==== Noncompliant code example`
Add rules 100-128 (#10) 2020-06-30 10:16:44 +02:00
Modify S109: Migrate To LayC (#3235) ## Review A dedicated reviewer checked the rule description successfully for: - [x] logical errors and incorrect information - [x] information gaps and missing content - [x] text style and tone - [x] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) 2023-10-11 13:58:56 +02:00			`[source,abap,diff-id=1,diff-type=noncompliant]`
Add rules 100-128 (#10) 2020-06-30 10:16:44 +02:00			`----`
Modify S109: Migrate To LayC (#3235) ## Review A dedicated reviewer checked the rule description successfully for: - [x] logical errors and incorrect information - [x] information gaps and missing content - [x] text style and tone - [x] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) 2023-10-11 13:58:56 +02:00			`IF sy-subrc EQ 42. " Noncompliant - 5 is a magic number`
			`screen-request = 'OK'.`
Add rules 100-128 (#10) 2020-06-30 10:16:44 +02:00			`ENDIF.`
			`----`

Modify S109: Migrate To LayC (#3235) ## Review A dedicated reviewer checked the rule description successfully for: - [x] logical errors and incorrect information - [x] information gaps and missing content - [x] text style and tone - [x] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) 2023-10-11 13:58:56 +02:00			`==== Compliant solution`
Add rules 100-128 (#10) 2020-06-30 10:16:44 +02:00
Modify S109: Migrate To LayC (#3235) ## Review A dedicated reviewer checked the rule description successfully for: - [x] logical errors and incorrect information - [x] information gaps and missing content - [x] text style and tone - [x] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) 2023-10-11 13:58:56 +02:00			`[source,abap,diff-id=1,diff-type=compliant]`
Add rules 100-128 (#10) 2020-06-30 10:16:44 +02:00			`----`
			`answer = 42.`
Modify S109: Migrate To LayC (#3235) ## Review A dedicated reviewer checked the rule description successfully for: - [x] logical errors and incorrect information - [x] information gaps and missing content - [x] text style and tone - [x] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule) 2023-10-11 13:58:56 +02:00			`IF sy-subrc EQ answer. " Compliant`
			`screen-request = 'OK'.`
Add rules 100-128 (#10) 2020-06-30 10:16:44 +02:00			`ENDIF.`
			`----`
Export comments and rspec-to-rspec links from jira 2021-06-02 20:44:38 +02:00
Fix the comment display: rule-id, timestamp, GH visibility, link direction 2021-06-03 09:05:38 +02:00			`ifdef::env-github,rspecator-view[]`
RULEAPI-666: Migrate the "List of parameters", "Highlighting" and "Message" fields from jira RSPEC (#346) 2021-09-20 15:38:42 +02:00
			`'''`
			`== Implementation Specification`
			`(visible only on this page)`

			`include::../message.adoc[]`

RULEAPI-576: add a horizontal rule between rule description and comments 2021-06-08 15:52:13 +02:00			`'''`
Export comments and rspec-to-rspec links from jira 2021-06-02 20:44:38 +02:00			`== Comments And Links`
			`(visible only on this page)`

			`include::../comments-and-links.adoc[]`
Make sure that includes are always surrounded by empty lines (#2270) When an include is not surrounded by empty lines, its content is inlined on the same line as the adjacent content. That can lead to broken tags and other display issues. This PR fixes all such includes and introduces a validation step that forbids introducing the same problem again. 2023-06-22 10:38:01 +02:00
Fix the comment display: rule-id, timestamp, GH visibility, link direction 2021-06-03 09:05:38 +02:00			`endif::env-github,rspecator-view[]`