2023-10-13 13:50:06 +02:00
|
|
|
:true: true
|
|
|
|
|
:false: false
|
|
|
|
|
:ops: !, &&, ||, ==, !=
|
2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
|
2020-12-21 15:38:52 +01:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
|
2023-12-22 10:07:51 +01:00
|
|
|
=== Exceptions
|
|
|
|
|
|
|
|
|
|
The use of literal booleans in comparisons which use identity operators (`===` and `!==`) are ignored.
|
|
|
|
|
|
|
|
|
|
== How to fix it
|
|
|
|
|
|
|
|
|
|
include::../how-to-fix-it.adoc[]
|
|
|
|
|
|
2023-10-13 13:50:06 +02:00
|
|
|
=== Code examples
|
2020-12-21 15:38:52 +01:00
|
|
|
|
2023-10-13 13:50:06 +02:00
|
|
|
==== Noncompliant code example
|
|
|
|
|
|
|
|
|
|
[source,php,diff-id=1,diff-type=noncompliant]
|
2020-12-21 15:38:52 +01:00
|
|
|
----
|
|
|
|
|
if ($booleanVariable == true) { /* ... */ }
|
|
|
|
|
if ($booleanVariable != true) { /* ... */ }
|
|
|
|
|
if ($booleanVariable || false) { /* ... */ }
|
|
|
|
|
doSomething(!false);
|
|
|
|
|
----
|
|
|
|
|
|
2023-10-13 13:50:06 +02:00
|
|
|
==== Compliant solution
|
2020-12-21 15:38:52 +01:00
|
|
|
|
2023-10-13 13:50:06 +02:00
|
|
|
[source,php,diff-id=1,diff-type=compliant]
|
2020-12-21 15:38:52 +01:00
|
|
|
----
|
|
|
|
|
if ($booleanVariable) { /* ... */ }
|
|
|
|
|
if (!$booleanVariable) { /* ... */ }
|
|
|
|
|
if ($booleanVariable) { /* ... */ }
|
|
|
|
|
doSomething(true);
|
|
|
|
|
----
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
|
'''
|
|
|
|
|
== Implementation Specification
|
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2023-05-25 14:18:12 +02:00
|
|
|
=== on 4 May 2020, 13:31:08 Pierre-Yves Nicolas wrote:
|
|
|
|
|
In PHP, this rule should not apply to the operands of ternary operators, see SONARPHP-906.
|
|
|
|
|
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|
