2023-10-13 13:50:06 +02:00
|
|
|
:true: true
|
|
|
|
:false: false
|
|
|
|
:ops: !, &&, ||, ==, !=
|
2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2020-12-21 15:38:52 +01:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
2023-12-22 10:07:51 +01:00
|
|
|
== How to fix it
|
|
|
|
|
|
|
|
include::../how-to-fix-it.adoc[]
|
|
|
|
|
2023-10-13 13:50:06 +02:00
|
|
|
=== Code examples
|
2020-12-21 15:38:52 +01:00
|
|
|
|
2023-10-13 13:50:06 +02:00
|
|
|
==== Noncompliant code example
|
|
|
|
|
|
|
|
[source,scala,diff-id=1,diff-type=noncompliant]
|
2020-12-21 15:38:52 +01:00
|
|
|
----
|
|
|
|
if (booleanMethod() || false) { /* ... */ }
|
|
|
|
doSomething(!false)
|
|
|
|
|
|
|
|
booleanVariable = if (booleanMethod()) true else false
|
|
|
|
booleanVariable = if (booleanMethod()) true else exp
|
|
|
|
booleanVariable = if (booleanMethod()) false else exp
|
|
|
|
booleanVariable = if (booleanMethod()) exp else true
|
|
|
|
booleanVariable = if (booleanMethod()) exp else false
|
|
|
|
----
|
|
|
|
|
2023-10-13 13:50:06 +02:00
|
|
|
==== Compliant solution
|
2020-12-21 15:38:52 +01:00
|
|
|
|
2023-10-13 13:50:06 +02:00
|
|
|
[source,scala,diff-id=1,diff-type=compliant]
|
2020-12-21 15:38:52 +01:00
|
|
|
----
|
|
|
|
if (booleanMethod()) { /* ... */ }
|
|
|
|
doSomething(true)
|
|
|
|
|
|
|
|
booleanVariable = booleanMethod()
|
|
|
|
booleanVariable = booleanMethod() || exp
|
|
|
|
booleanVariable = !booleanMethod() && exp
|
|
|
|
booleanVariable = !booleanMethod() || exp
|
|
|
|
booleanVariable = booleanMethod() && exp
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2023-06-22 10:38:01 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|