rspec/rules/S1139/abap/rule.adoc

== Why is this an issue?

``++DELETE FROM dbtab++`` without a ``++WHERE++`` condition deletes all the entries of the table. Check whether dataset to be deleted can be limited by a suitable WHERE condition.

=== Noncompliant code example

[source,abap]
----
DELETE FROM COUNTRIES.
----

=== Compliant solution

[source,abap]
----
DELETE FROM COUNTRIES WHERE CODE = country_code.
----
ifdef::env-github,rspecator-view[]

'''
== Implementation Specification
(visible only on this page)

=== Message

Add a "WHERE" clause to this "DELETE" statement to prevent deleting all rows in table "XXX".


endif::env-github,rspecator-view[]
migrate rule descriptions to new education format 2023-05-03 11:06:20 +02:00			`== Why is this an issue?`

make in-line code blocks verbatim 2021-01-27 13:42:22 +01:00			``++DELETE FROM dbtab++`` without a ``++WHERE++`` condition deletes all the entries of the table. Check whether dataset to be deleted can be limited by a suitable WHERE condition.
Add rules 1000-1999 2020-06-30 12:47:33 +02:00
migrate rule descriptions to new education format 2023-05-03 11:06:20 +02:00			`=== Noncompliant code example`
Add rules 1000-1999 2020-06-30 12:47:33 +02:00
RULEAPI-661: Add syntax coloring 2022-02-04 17:28:24 +01:00			`[source,abap]`
Add rules 1000-1999 2020-06-30 12:47:33 +02:00			`----`
			`DELETE FROM COUNTRIES.`
			`----`

migrate rule descriptions to new education format 2023-05-03 11:06:20 +02:00			`=== Compliant solution`
Add rules 1000-1999 2020-06-30 12:47:33 +02:00
RULEAPI-661: Add syntax coloring 2022-02-04 17:28:24 +01:00			`[source,abap]`
Add rules 1000-1999 2020-06-30 12:47:33 +02:00			`----`
			`DELETE FROM COUNTRIES WHERE CODE = country_code.`
			`----`
RULEAPI-666: Migrate the "List of parameters", "Highlighting" and "Message" fields from jira RSPEC (#346) 2021-09-20 15:38:42 +02:00			`ifdef::env-github,rspecator-view[]`

			`'''`
			`== Implementation Specification`
			`(visible only on this page)`

Clean rule at root In some cases, the `rule.adoc` at root of a rule is never included anywhere and thus is dead code. It's a maintenance cost by itself, but also it misses opportunities to inline code that seems used by two documents when in fact only one document is actually rendered. And this missed opportunity, in turn, stops us from applying the correct language tag on the code samples. 2023-10-16 16:34:38 +02:00			`=== Message`

			`Add a "WHERE" clause to this "DELETE" statement to prevent deleting all rows in table "XXX".`

RULEAPI-666: Migrate the "List of parameters", "Highlighting" and "Message" fields from jira RSPEC (#346) 2021-09-20 15:38:42 +02:00
			`endif::env-github,rspecator-view[]`