rspec/rules/S2486/rpg/rule.adoc

54 lines
1.0 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Leaving an ``++ON-ERROR++`` block empty means that the exception in question is neither handled nor passed forward to callers for handling at a higher level. Suppressing errors rather than handling them could lead to unpredictable system behavior and should be avoided.
2020-06-30 12:48:07 +02:00
=== Noncompliant code example
2020-06-30 12:48:07 +02:00
2022-02-04 17:28:24 +01:00
[source,rpg]
2020-06-30 12:48:07 +02:00
----
/free
monitor;
// ...
on-error *FILE; // Noncompliant
endmon;
/end-free
----
=== Compliant solution
2020-06-30 12:48:07 +02:00
2022-02-04 17:28:24 +01:00
[source,rpg]
2020-06-30 12:48:07 +02:00
----
/free
monitor;
// ...
on-error *FILE;
handleFileError();
endmon;
/end-free
----
=== Exceptions
2020-06-30 12:48:07 +02:00
When a block contains a comment, it is not considered to be empty.
include::../see.adoc[]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Either handle this XXX error or allow it to propagate.
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]