2023-08-04 12:58:46 +02:00
This rule raises an issue when a function call result is used, even though the function does not return anything.
2023-05-03 11:06:20 +02:00
== Why is this an issue?
2022-03-22 10:32:09 +01:00
If a function does not return anything, it makes no sense to use its output. Specifically, passing it to another function, or assigning its "result" to a variable is probably a bug because such functions return nothing, which is probably not what was intended.
2023-08-04 12:58:46 +02:00
=== Code examples
==== Noncompliant code example
2022-03-22 10:32:09 +01:00
2023-08-04 12:58:46 +02:00
[source,python,diff-id=1,diff-type=noncompliant]
2022-03-22 10:32:09 +01:00
----
def foo():
l = [1, 2, 3]
result = l.append(42) # Noncompliant, `append` mutates list l
return result
----
2023-08-04 12:58:46 +02:00
==== Compliant solution
2022-03-22 10:32:09 +01:00
2023-08-04 12:58:46 +02:00
[source,python,diff-id=1,diff-type=compliant]
2022-03-22 10:32:09 +01:00
----
def foo():
l = [1, 2, 3]
l.append(42)
return l
----
2021-06-02 20:44:38 +02:00
2023-08-04 12:58:46 +02:00
== Resources
=== Documentation
* Python documentation - https://docs.python.org/3/tutorial/controlflow.html#defining-functions[Defining Functions]
2021-06-03 09:05:38 +02:00
ifdef::env-github,rspecator-view[]
2021-09-20 15:38:42 +02:00
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
2021-06-08 15:52:13 +02:00
'''
2021-06-02 20:44:38 +02:00
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
2023-06-22 10:38:01 +02:00
2021-06-03 09:05:38 +02:00
endif::env-github,rspecator-view[]