rspec/rules/S1151/apex/rule.adoc

48 lines
1.0 KiB
Plaintext
Raw Normal View History

2021-01-27 13:42:22 +01:00
The ``++switch++`` statement should be used only to clearly define some new branches in the control flow. As soon as a ``++when++`` clause contains too many statements this highly decreases the readability of the overall control flow statement. In such case, the content of the ``++when++`` clause should be extracted into a dedicated function.
2020-06-30 12:47:33 +02:00
== Noncompliant Code Example
2021-01-27 13:42:22 +01:00
With the threshold set at ``++5++``:
2020-06-30 12:47:33 +02:00
----
public void foo(Integer value) {
switch on value {
when 1 {
methodCall1('');
methodCall2('');
methodCall3('');
methodCall4('');
methodCall5('');
}
when 2 { /* ... */ }
}
}
----
== Compliant Solution
----
public void foo(Integer value) {
switch on value {
when 1 { doSomething(); }
when 2 { /* ... */ }
}
}
}
private void doSomething() {
methodCall1('');
methodCall2('');
methodCall3('');
methodCall4('');
methodCall5('');
}
----
ifdef::rspecator-view[]
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::rspecator-view[]