19 lines
1017 B
Plaintext
19 lines
1017 B
Plaintext
|
=== On 2013-08-23T08:38:39Z Dinesh Bolkensteyn Wrote:
|
||
|
|
Implemented by \http://jira.codehaus.org/browse/SONARJAVA-320
|
||
|
|
|
||
|
|
=== On 2013-08-24T18:25:46Z Ann Campbell Wrote:
|
||
|
|
The advice here is to move to an enum, but an enum may not be appropriate for the constants involved. The typical advice (Bloch's advice too) appears to make the constants public static final in a class with a private constructor...?
|
||
|
|
|
||
|
|
=== On 2013-08-24T18:29:43Z Ann Campbell Wrote:
|
||
|
|
I question the advice we're giving here...
|
||
|
|
|
||
|
|
=== On 2013-08-26T04:43:19Z Dinesh Bolkensteyn Wrote:
|
||
|
|
hm, a utilitly class? Those aren't really nice to use - and is listed as last option (3) in Effective Java.
|
||
|
|
|
||
|
|
|
||
|
|
But indeed he suggests to 1) add constants such as Integer.MAX_VALUE and Integer.MIN_VALUE to the Integer class directly *or* 2) to move them to an enum if applicable
|
||
|
|
|
||
|
|
=== On 2013-08-26T04:51:26Z Dinesh Bolkensteyn Wrote:
|
||
|
|
\[~ann.campbell.2] Does this updated issue message work for you? 'Move these constants either into an enum or to the implementing class.'
|
||
|
|
|