rspec/rules/S1862/rpg/rule.adoc

76 lines
1.7 KiB
Plaintext
Raw Normal View History

2021-01-27 13:42:22 +01:00
A ``++Select++`` or a chain of ``++If++``/``++Elseif++`` statements is evaluated from top to bottom. At most, only one branch will be executed: the first one with a condition that evaluates to ``++true++``.
2020-06-30 12:47:33 +02:00
2021-02-02 15:02:10 +01:00
2020-06-30 12:47:33 +02:00
Therefore, duplicating a condition automatically leads to dead code. Usually, this is due to a copy/paste error. At best, it's simply dead code and at worst, it's a bug that is likely to induce further bugs as the code is maintained, and obviously it could lead to unexpected behavior.
== Noncompliant Code Example
----
C IF X = 1
C EXSR SR01
C ELSEIF X = 1 Noncompliant
C EXSR SR02
C ENDIF
----
----
/free
IF param = 1;
doX();
ELSEIF param = 2;
doY();
ELSEIF param = 1; // Noncompliant
doZ();
ENDIF;
SELECT;
WHEN param = 1;
doX();
WHEN param = 2;
doY();
WHEN param = 1; // Noncompliant
doZ();
ENDSL;
/end-free
----
== Compliant Solution
----
C IF X = 1
C EXSR SR01
C ELSEIF X = 2
C EXSR SR02
C ENDIF
----
----
/free
IF param = 1;
doX();
ELSEIF param = 2;
doY();
ELSEIF param = 3;
doZ();
ENDIF;
SELECT;
WHEN param = 1;
doX();
WHEN param = 2;
doY();
WHEN param = 3;
doZ();
ENDSL;
/end-free
----
include::../see.adoc[]
ifdef::rspecator-view[]
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::rspecator-view[]