2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2023-03-14 15:55:28 +01:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Noncompliant code example
|
2023-03-14 15:55:28 +01:00
|
|
|
|
|
|
|
[source,csharp]
|
|
|
|
----
|
|
|
|
public struct Coordinates
|
|
|
|
{
|
|
|
|
public int X { get; }
|
|
|
|
public int Y { get; }
|
|
|
|
|
|
|
|
[ExcludeFromCodeCoverage] // Noncompliant
|
|
|
|
public override bool Equals(object obj) => obj is Coordinates coordinates && X == coordinates.X && Y == coordinates.Y;
|
|
|
|
|
|
|
|
[ExcludeFromCodeCoverage] // Noncompliant
|
|
|
|
public override int GetHashCode()
|
|
|
|
{
|
|
|
|
var hashCode = 1861411795;
|
|
|
|
hashCode = hashCode * -1521134295 + X.GetHashCode();
|
|
|
|
hashCode = hashCode * -1521134295 + Y.GetHashCode();
|
|
|
|
return hashCode;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Compliant solution
|
2023-03-14 15:55:28 +01:00
|
|
|
|
|
|
|
[source,csharp]
|
|
|
|
----
|
|
|
|
public struct Coordinates
|
|
|
|
{
|
|
|
|
public int X { get; }
|
|
|
|
public int Y { get; }
|
|
|
|
|
|
|
|
[ExcludeFromCodeCoverage(Justification = "Code generated by Visual Studio refactoring")] // Compliant
|
|
|
|
public override bool Equals(object obj) => obj is Coordinates coordinates && X == coordinates.X && Y == coordinates.Y;
|
|
|
|
|
|
|
|
[ExcludeFromCodeCoverage(Justification = "Code generated by Visual Studio refactoring")] // Compliant
|
|
|
|
public override int GetHashCode()
|
|
|
|
{
|
|
|
|
var hashCode = 1861411795;
|
|
|
|
hashCode = hashCode * -1521134295 + X.GetHashCode();
|
|
|
|
hashCode = hashCode * -1521134295 + Y.GetHashCode();
|
|
|
|
return hashCode;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
2023-05-25 14:18:12 +02:00
|
|
|
include::../see.adoc[]
|