rspec/rules/S3909/csharp/rule.adoc

73 lines
1.0 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-04-28 16:49:39 +02:00
The NET Framework 2.0 introduced the generic interface ``++System.Collections.Generic.IEnumerable<T>++`` and it should be preferred over the older, non generic, interfaces.
This rule raises an issue when a public type implements ``++System.Collections.IEnumerable++``.
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,csharp]
2021-04-28 16:49:39 +02:00
----
using System;
using System.Collections;
public class MyData
{
public MyData()
{
}
}
public class MyList : CollectionBase // Noncompliant
{
public void Add(MyData data)
{
InnerList.Add(data);
}
// ...
}
----
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,csharp]
2021-04-28 16:49:39 +02:00
----
using System;
using System.Collections.ObjectModel;
public class MyData
{
public MyData()
{
}
}
public class MyList : Collection<MyData>
{
// Implementation...
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Refactor this collection to implement [IEnumerable<T>|ICollection<T>|IList<T>]
=== Highlighting
Class declaration
endif::env-github,rspecator-view[]