65 lines
1.0 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-04-28 16:49:39 +02:00
Unlike strongly typed languages, JavaScript does not enforce a return type on a function. This means that different paths through a function can return different types of values, which can be very confusing to the user and significantly harder to maintain.
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,javascript]
2021-04-28 16:49:39 +02:00
----
function foo(a) { // Noncompliant
if (a === 1) {
return true;
}
return 3;
}
----
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,javascript]
2021-04-28 16:49:39 +02:00
----
function foo(a) {
if (a === 1) {
return true;
}
return false;
}
----
=== Exceptions
2021-04-28 16:49:39 +02:00
Functions returning ``++this++`` are ignored.
[source,javascript]
2021-04-28 16:49:39 +02:00
----
function foo() {
// ...
return this;
}
----
Functions returning expressions having type ``++any++`` are ignored.
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Refactor this function to always return the same type.
=== Highlighting
Primary: function name/declaration
Secondary: Return statements
endif::env-github,rspecator-view[]