2023-05-03 11:06:20 +02:00
== Why is this an issue?
2021-04-28 16:49:39 +02:00
Unlike strongly typed languages, JavaScript does not enforce a return type on a function. This means that different paths through a function can return different types of values, which can be very confusing to the user and significantly harder to maintain.
2021-04-28 18:08:03 +02:00
2023-05-03 11:06:20 +02:00
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,javascript]
2021-04-28 16:49:39 +02:00
----
function foo(a) { // Noncompliant
if (a === 1) {
return true;
}
return 3;
}
----
2021-04-28 18:08:03 +02:00
2023-05-03 11:06:20 +02:00
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,javascript]
2021-04-28 16:49:39 +02:00
----
function foo(a) {
if (a === 1) {
return true;
}
return false;
}
----
2021-04-28 18:08:03 +02:00
2023-05-03 11:06:20 +02:00
=== Exceptions
2021-04-28 16:49:39 +02:00
Functions returning ``++this++`` are ignored.
2022-08-04 15:12:16 +02:00
[source,javascript]
2021-04-28 16:49:39 +02:00
----
function foo() {
// ...
return this;
}
----
Functions returning expressions having type ``++any++`` are ignored.
2021-04-28 18:08:03 +02:00
2021-09-20 15:38:42 +02:00
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
2023-05-25 14:18:12 +02:00
=== Message
Refactor this function to always return the same type.
=== Highlighting
Primary: function name/declaration
Secondary: Return statements
2021-09-20 15:38:42 +02:00
endif::env-github,rspecator-view[]