2020-06-30 10:16:44 +02:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
|
|
|
== Noncompliant Code Example
|
|
|
|
|
|
|
|
----
|
|
|
|
public static void DoSomething()
|
|
|
|
{
|
|
|
|
for(int i = 0; i < 4; i++) // Noncompliant, 4 is a magic number
|
|
|
|
{
|
|
|
|
...
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
|
|
|
== Compliant Solution
|
|
|
|
|
|
|
|
----
|
|
|
|
private const int NUMBER_OF_CYCLES = 4;
|
|
|
|
|
|
|
|
public static void DoSomething()
|
|
|
|
{
|
|
|
|
for(int i = 0; i < NUMBER_OF_CYCLES ; i++) //Compliant
|
|
|
|
{
|
|
|
|
...
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
|
|
|
== Exceptions
|
|
|
|
|
2021-01-27 13:42:22 +01:00
|
|
|
This rule doesn't raise an issue when the magic number is used as part of the ``++GetHashCode++`` method or a variable/field declaration.
|