rspec/rules/S3053/java/rule.adoc

46 lines
839 B
Plaintext
Raw Normal View History

2021-04-28 16:49:39 +02:00
If you've gone to the trouble of writing an ``++iterator++`` method in a class that doesn't implement ``++Iterable++``, that trivial omission is costing you half the benefit of the method because you can't use the class in enhanced ``++for++`` loops.
2021-04-28 16:49:39 +02:00
== Noncompliant Code Example
----
public class MyList { // Noncompliant
public Iterator iterator() {
//...
}
}
public class MyClass {
public void doSomething(MyList myList) {
Iterator itr = myList.iterator();
while (itr.hasNext() {
Object obj = itr.next();
processObj(obj);
}
}
}
----
2021-04-28 16:49:39 +02:00
== Compliant Solution
----
public class MyList implements Iterable{
public Iterator iterator() {
//...
}
}
public class MyClass {
public void doSomething(MyList myList) {
for(Object obj : myList) {
processObj(obj);
}
}
}
----