rspec/rules/S3923/python/rule.adoc

27 lines
647 B
Plaintext
Raw Normal View History

2021-01-27 13:42:22 +01:00
Having the same implementation in every branch of an ``++if++`` chain is an error. Either a copy-paste error was made and something different should be executed, or there shouldn't be an ``++if++`` chain at all.
2020-06-30 12:48:39 +02:00
== Noncompliant Code Example
----
if b == 0: # Noncompliant
doOneMoreThing()
elif b == 1:
doOneMoreThing()
else:
doOneMoreThing()
b = 4 if a > 12 else 4 # Noncompliant
----
== Exceptions
2021-01-27 13:42:22 +01:00
This rule does not apply to ``++if++`` chains without ``++else++``-s.
2020-06-30 12:48:39 +02:00
2021-02-02 15:02:10 +01:00
2020-06-30 12:48:39 +02:00
----
if b == 0: # no issue, this could have been done on purpose to make the code more readable
doOneMoreThing()
elif b == 1:
doOneMoreThing()
----