ishangsf/rspec
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
rspec/rules/S5542/python/how-to-fix-it/pycrypto.adoc

51 lines
1.0 KiB
Plaintext
Raw Normal View History

Modify S5542: Learn-As-You-Code migration (#2011) Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-20 10:27:53 +02:00
== How to fix it in PyCrypto
=== Code examples
==== Noncompliant code example
include::../../common/fix/aes-noncompliant-example.adoc[]
Diff blocks: fix incorrect use for python (#2795) Improvement identified in #2790. Add a prefix to the diff-id when it is used multiple times in different "how to fix it in XYZ" sections to avoid ambiguity and pedantically follow the spec: > A single and unique diff-id should be used only once for each type of code example as shown in the description of a rule. Obvious typos around `diff-type` were fixed. An obvious extra use of diff blocks was removed.
2023-08-21 15:22:49 +02:00
[source,python,diff-id=11,diff-type=noncompliant]
Modify S5542: Learn-As-You-Code migration (#2011) Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-20 10:27:53 +02:00
----
from Crypto.Cipher import AES
AES.new(key, AES.MODE_ECB) # Noncompliant
----
include::../../common/fix/rsa-noncompliant-example.adoc[]
Diff blocks: fix incorrect use for python (#2795) Improvement identified in #2790. Add a prefix to the diff-id when it is used multiple times in different "how to fix it in XYZ" sections to avoid ambiguity and pedantically follow the spec: > A single and unique diff-id should be used only once for each type of code example as shown in the description of a rule. Obvious typos around `diff-type` were fixed. An obvious extra use of diff blocks was removed.
2023-08-21 15:22:49 +02:00
[source,python,diff-id=12,diff-type=noncompliant]
Modify S5542: Learn-As-You-Code migration (#2011) Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-20 10:27:53 +02:00
----
from Crypto.Cipher import PKCS1_v1_5
PKCS1_v1_5.new(key) # Noncompliant
----
==== Compliant solution
Since PyCrypto is not supported anymore, another library should be used.
In the current context, Cryptodome uses a similar API.
include::../../common/fix/aes-compliant-example.adoc[]
Diff blocks: fix incorrect use for python (#2795) Improvement identified in #2790. Add a prefix to the diff-id when it is used multiple times in different "how to fix it in XYZ" sections to avoid ambiguity and pedantically follow the spec: > A single and unique diff-id should be used only once for each type of code example as shown in the description of a rule. Obvious typos around `diff-type` were fixed. An obvious extra use of diff blocks was removed.
2023-08-21 15:22:49 +02:00
[source,python,diff-id=11,diff-type=compliant]
Modify S5542: Learn-As-You-Code migration (#2011) Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-20 10:27:53 +02:00
----
from Crypto.Cipher import AES
AES.new(key, AES.MODE_GCM)
----
include::../../common/fix/rsa-compliant-example.adoc[]
Diff blocks: fix incorrect use for python (#2795) Improvement identified in #2790. Add a prefix to the diff-id when it is used multiple times in different "how to fix it in XYZ" sections to avoid ambiguity and pedantically follow the spec: > A single and unique diff-id should be used only once for each type of code example as shown in the description of a rule. Obvious typos around `diff-type` were fixed. An obvious extra use of diff blocks was removed.
2023-08-21 15:22:49 +02:00
[source,python,diff-id=12,diff-type=compliant]
Modify S5542: Learn-As-You-Code migration (#2011) Co-authored-by: hendrik-buchwald-sonarsource <64110887+hendrik-buchwald-sonarsource@users.noreply.github.com>
2023-06-20 10:27:53 +02:00
----
from Crypto.Cipher import PKCS1_OAEP
PKCS1_OAEP.new(key)
----
=== How does this work?
include::../../common/fix/fix.adoc[]
Reference in New Issue Copy Permalink