73 lines
1.4 KiB
Plaintext
Raw Normal View History

include::../description.adoc[]
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
include::../ask-yourself.adoc[]
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
include::../recommended.adoc[]
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
== Sensitive Code Example
For Typical identity blocks:
[source,terraform,diff-id=1,diff-type=noncompliant]
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
----
resource "azurerm_api_management" "example" { # Sensitive, the identity block is missing
name = "example"
publisher_name = "company"
}
----
For connections between Kusto Clusters and Azure Data Factory:
[source,terraform,diff-id=2,diff-type=noncompliant]
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
----
resource "azurerm_data_factory_linked_service_kusto" "example" {
name = "example"
use_managed_identity = false # Sensitive
}
----
== Compliant Solution
For Typical identity blocks:
[source,terraform,diff-id=1,diff-type=compliant]
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
----
resource "azurerm_api_management" "example" {
name = "example"
publisher_name = "company"
identity {
type = "SystemAssigned"
}
}
----
For connections between Kusto Clusters and Azure Data Factory:
[source,terraform,diff-id=2,diff-type=compliant]
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
----
resource "azurerm_data_factory_linked_service_kusto" "example" {
name = "example"
use_managed_identity = true
}
----
include::../see.adoc[]
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
Only for Azure Data Factory:
- Make sure that disabling Azure Managed Identities is safe here.
include::../highlighting.adoc[]
2022-01-25 18:36:46 +01:00
Create rule S6378[terraform] : Disabling Managed Identities for Azure resources is security-sensitive (#569) * clean-up old metadata file * Create rule S6378 * Add first draft * added link to managed service resources list * fix vague title * add metadata tagging * add metadata - sec standards * add owasp ref * add concise var names Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * add concise var names and reduces identity.type Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/description.adoc * add other distinct code sample * add down to earth recos Clear-text credentials || third party systems * add description - clearer on M-Identities stakes * changed remediation cost to 1h * add cleared reco - use system-assigned * fix layout pb * fix metadata 'hour' mistake: 'hour'->'h' * reformulate ask-yourself * fixed potential confusion * applied review suggestions * add highlight * Update rules/S6378/metadata.json * Update rules/S6378/message.adoc Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> * Update rules/S6378/metadata.json * Update rules/S6378/ask-yourself.adoc Co-authored-by: Loris Sierra <loris.sierra@sonarsource.com> Co-authored-by: loris-s-sonarsource <loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Loris S <91723853+loris-s-sonarsource@users.noreply.github.com> Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com> Co-authored-by: Nils Werner <64034005+nils-werner-sonarsource@users.noreply.github.com>
2021-12-14 09:37:33 +00:00
endif::env-github,rspecator-view[]