rspec/rules/S3923/vbnet/rule.adoc

37 lines
827 B
Plaintext
Raw Normal View History

2020-12-23 14:59:06 +01:00
Having all branches in a ``Select Case`` or ``If`` chain with the same implementation is an error. Either a copy-paste error was made and something different should be executed, or there shouldn't be a ``Select Case`` / ``If`` chain at all.
2020-06-30 12:48:39 +02:00
== Noncompliant Code Example
----
Dim b As Integer = If(a > 12, 4, 4)
If b = 0 Then
DoTheThing()
Else
DoTheThing()
End If
Select Case i
Case 1
DoSomething()
Case 2
DoSomething()
Case 3
DoSomething()
Case Else
DoSomething()
End Select
----
== Exceptions
2020-12-23 14:59:06 +01:00
This rule does not apply to ``If`` chains without ``Else``-s, or to ``Select Case``-es without ``Case Else`` clauses.
2020-06-30 12:48:39 +02:00
----
If b = 0 Then ' No issue, this could have been done on purpose to make the code more readable
DoTheThing()
ElseIf
DoTheThing()
End If
----