rspec/rules/S1128/csharp/rule.adoc

74 lines
1.7 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Although unnecessary ``++using++`` won't change anything to the produced application, removing them:
2020-06-30 12:47:33 +02:00
* Will help readability and maintenance.
* Will help reduce the number of items in the IDE auto-completion list when coding.
* May avoid some name collisions.
* May improve compilation time because the compiler has fewer namespaces to look-up when it resolves types.
* The build will fail if this namespace is removed from the project.
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,csharp]
2020-06-30 12:47:33 +02:00
----
using System.Collections.Generic; // Noncompliant - unnecessary using
namespace Foo
{
public class Bar
{
public Bar(string path)
{
File.ReadAllLines(path);
}
}
}
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,csharp]
2020-06-30 12:47:33 +02:00
----
using System.IO;
namespace Foo
{
public class Bar
{
public Bar(string path)
{
File.ReadAllLines(path);
}
}
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
* Remove this unused "using".
'''
== Comments And Links
(visible only on this page)
=== on 23 Sep 2019, 16:37:14 Nicolas Harraudeau wrote:
*OUT OF SCOPE*
Duplicate imports are out of scopes as Roslyn already raises an issue in this case. As Roslyn issues are enabled by default this would simply create duplicates.
=== on 18 Dec 2020, 10:06:15 Andrei Epure wrote:
We are removing this rule from SonarWay due to its performance issues. After the rule gets re-designed to avoid perf issues, (see https://github.com/SonarSource/sonar-dotnet/issues/3761[#3761]), we should bring it back to SonarWay.
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]