rspec/rules/S1186/java/rule.adoc

76 lines
1.4 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
:operationName: method
2020-06-30 12:47:33 +02:00
include::../description.adoc[]
2021-02-02 15:02:10 +01:00
=== Exceptions
This does not raise an issue in the following cases:
2020-06-30 12:47:33 +02:00
* Non-public default (no-argument) constructors
* Public default (no-argument) constructors when there are other constructors in the class
* Empty methods in abstract classes
* Methods annotated with `@org.aspectj.lang.annotation.Pointcut()`
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2020-06-30 12:47:33 +02:00
----
public abstract class Animal {
void speak() { // default implementation ignored
}
2020-06-30 12:47:33 +02:00
}
----
== How to fix it
2020-06-30 12:47:33 +02:00
=== Code examples
==== Noncompliant code example
[source,java,diff-id=1,diff-type=noncompliant]
2020-06-30 12:47:33 +02:00
----
public void shouldNotBeEmpty() { // Noncompliant - method is empty
}
public void notImplemented() { // Noncompliant - method is empty
2020-06-30 12:47:33 +02:00
}
@Override
public void emptyOnPurpose() { // Noncompliant - method is empty
2020-06-30 12:47:33 +02:00
}
----
==== Compliant solution
2020-06-30 12:47:33 +02:00
[source,java,diff-id=1,diff-type=compliant]
----
public void doSomething() {
doSomething();
}
2020-06-30 12:47:33 +02:00
public void notImplemented() {
throw new UnsupportedOperationException("notImplemented() cannot be performed because ...");
}
2021-02-02 15:02:10 +01:00
@Override
public void emptyOnPurpose() {
// comment explaining why the method is empty
2020-06-30 12:47:33 +02:00
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]