rspec/rules/S5693/java/rule.adoc

79 lines
1.7 KiB
Plaintext
Raw Normal View History

2021-01-27 04:07:23 +00:00
include::../description.adoc[]
include::../ask-yourself.adoc[]
include::../recommended.adoc[]
== Sensitive Code Example
2021-02-11 16:56:46 +01:00
With default limit value of 8388608 (8MB).
2021-01-27 04:07:23 +00:00
A 100 MB file is allowed to be uploaded:
[source,java]
2021-01-27 04:07:23 +00:00
----
@Bean(name = "multipartResolver")
public CommonsMultipartResolver multipartResolver() {
CommonsMultipartResolver multipartResolver = new CommonsMultipartResolver();
2021-02-11 16:56:46 +01:00
multipartResolver.setMaxUploadSize(104857600); // Sensitive (100MB)
return multipartResolver;
}
@Bean(name = "multipartResolver")
public CommonsMultipartResolver multipartResolver() {
CommonsMultipartResolver multipartResolver = new CommonsMultipartResolver(); // Sensitive, by default if maxUploadSize property is not defined, there is no limit and thus it's insecure
2021-01-27 04:07:23 +00:00
return multipartResolver;
}
2021-02-11 16:56:46 +01:00
@Bean
public MultipartConfigElement multipartConfigElement() {
MultipartConfigFactory factory = new MultipartConfigFactory(); // Sensitive, no limit by default
return factory.createMultipartConfig();
}
2021-01-27 04:07:23 +00:00
----
== Compliant Solution
2021-01-27 12:06:36 +01:00
File upload size is limited to 8 MB:
2021-01-27 04:07:23 +00:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-01-27 04:07:23 +00:00
----
@Bean(name = "multipartResolver")
public CommonsMultipartResolver multipartResolver() {
2021-02-11 16:56:46 +01:00
multipartResolver.setMaxUploadSize(8388608); // Compliant (8 MB)
2021-01-27 04:07:23 +00:00
return multipartResolver;
}
----
include::../see.adoc[]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
=== Parameters
.fileUploadSizeLimit
****
_integer_
----
8388608
----
The maximum size of HTTP requests handling file uploads (in bytes)
****
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]