rspec/rules/S3054/java/rule.adoc

55 lines
1.0 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-04-28 16:49:39 +02:00
Each constructor must first invoke a parent class constructor, but it doesn't always have to be done explicitly. If the parent class has a reachable, no-args constructor, a call to it will be inserted automatically by the compiler. Thus, calls to ``++super()++`` can be omitted.
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
public class MyClass {
private Foo foo;
public MyClass (Foo foo) {
super(); // Noncompliant
this.foo = foo;
}
----
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
public class MyClass {
private Foo foo;
public MyClass (Foo foo) {
this.foo = foo;
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Remove this "super()" call; it is inserted automatically by the compiler.
'''
== Comments And Links
(visible only on this page)
=== on 12 Jun 2015, 14:11:56 Ann Campbell wrote:
CodePro: Invocation of Default Constructor
=== on 23 Jul 2015, 07:11:38 Nicolas Peru wrote:
LGTM
endif::env-github,rspecator-view[]