54 lines
1.0 KiB
Plaintext
Raw Normal View History

=== How to fix it in ASP.NET
include::../../common/fix/code-rationale.adoc[]
==== Non-compliant code example
[source,csharp,diff-id=1,diff-type=noncompliant]
----
using System.Web;
using System.Web.Mvc;
public class ExampleController : Controller
{
[HttpGet]
public IActionResult ImageFetch(string location)
{
HttpWebRequest request = (HttpWebRequest)WebRequest.Create(location);
return Ok();
}
}
----
==== Compliant solution
[source,csharp,diff-id=1,diff-type=compliant]
----
using System.Web;
using System.Web.Mvc;
public class ExampleController : Controller
{
private readonly string[] allowedUrls = { "www.example.com", "example.com" };
[HttpGet]
public IActionResult ImageFetch(string location)
{
Uri uri = new Uri(location);
if (!allowedUrls.Contains(uri.Host))
{
return BadRequest();
}
HttpWebRequest request = (HttpWebRequest)WebRequest.Create(uri);
return Ok();
}
}
----
include::../../common/fix/how-does-this-work.adoc[]