rspec/rules/S109/vbnet/rule.adoc

55 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2020-06-30 10:16:44 +02:00
A magic number is a number that comes out of nowhere, and is directly used in a statement. Magic numbers are often used, for instance to limit the number of iterations of a loops, to test the value of a property, etc.
2021-02-02 15:02:10 +01:00
2020-06-30 10:16:44 +02:00
Using magic numbers may seem obvious and straightforward when you're writing a piece of code, but they are much less obvious and straightforward at debugging time.
2021-02-02 15:02:10 +01:00
2020-06-30 10:16:44 +02:00
That is why magic numbers must be demystified by first being assigned to clearly named constants before being used.
=== Noncompliant code example
2020-06-30 10:16:44 +02:00
2022-02-04 17:28:24 +01:00
[source,vbnet]
2020-06-30 10:16:44 +02:00
----
Class Foo
Sub DoSomething(Param As Integer)
If Param > 100 Then ' Magic Number
' Do something
End If
End Sub
End Class
----
=== Compliant solution
2020-06-30 10:16:44 +02:00
2022-02-04 17:28:24 +01:00
[source,vbnet]
2020-06-30 10:16:44 +02:00
----
Class Foo
Private Const MaxOfSomething As Integer = 100
Sub DoSomething(Param As Integer)
If Param > MaxOfSomething Then
' Do something
End If
End Sub
End Class
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::parameters.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]