rspec/rules/S3923/abap/rule.adoc

56 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Having all branches in a ``++CASE++`` or ``++IF++`` chain with the same implementation is an error. Either a copy-paste error was made and something different should be executed, or there shouldn't be a ``++CASE++``/``++IF++`` chain at all.
2020-06-30 12:48:39 +02:00
=== Noncompliant code example
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,abap]
2020-06-30 12:48:39 +02:00
----
IF a >0.
doSomething.
ELSE IF b> 0.
doSomething.
ELSE.
doSomething.
ENDIF.
CASE i.
WHEN 1 OR 3.
doSomething.
WHEN 2.
doSomething.
WHEN OTHERS.
doSomething.
ENDCASE.
----
=== Exceptions
2020-06-30 12:48:39 +02:00
2021-01-27 13:42:22 +01:00
Note that this rule does not apply to ``++IF++`` chains without final ``++ELSE++``-s, or to ``++CASE++``-s without ``++WHEN OTHERS++`` clauses.
2020-06-30 12:48:39 +02:00
2021-02-02 15:02:10 +01:00
2020-06-30 12:48:39 +02:00
----
IF a >0. "no issue, this could have been done on purpose to make the code more readable
doSomething.
ELSEIF b> 0.
doSomething.
ENDIF.
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]