rspec/rules/S3923/ruby/rule.adoc

58 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Having all branches in a ``++case++`` or ``++if++`` chain with the same implementation is an error. Either a copy-paste error was made and something different should be executed, or there shouldn't be a ``++case++``/``++if++`` chain at all.
2020-06-30 12:48:39 +02:00
=== Noncompliant code example
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,ruby]
2020-06-30 12:48:39 +02:00
----
if b == 0 # Noncompliant
doOneMoreThing()
else
doOneMoreThing()
end
b = a > 12 ? 4 : 4; # Noncompliant
case i # Noncompliant
when 1
doSomething()
when 2
doSomething()
when 3
doSomething()
else
doSomething()
end
----
=== Exceptions
2020-06-30 12:48:39 +02:00
2021-01-27 13:42:22 +01:00
This rule does not apply to ``++if++`` chains or ``++case++``-es without ``++else++``-s.
2020-06-30 12:48:39 +02:00
2021-02-02 15:02:10 +01:00
2020-06-30 12:48:39 +02:00
----
if b == 0 # no issue, this could have been done on purpose to make the code more readable
doSomething()
elsif b == 1
doSomething()
end
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]