rspec/rules/S3923/tsql/rule.adoc

54 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Having all branches in a ``++CASE++``, ``++IF++`` or ``++IIF++`` chain with the same implementation is an error. Either a copy-paste error was made and something different should be executed, or there shouldn't be a ``++CASE++``/``++IF++``/``++IIF++`` chain at all.
2020-06-30 12:48:39 +02:00
=== Noncompliant code example
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:48:39 +02:00
----
IF @x < 25 -- Noncompliant
PRINT 'A'
ELSE IF @x < 10
PRINT 'A'
ELSE
PRINT 'A'
SELECT
CASE col1 -- Noncompliant
WHEN 1 THEN 'A'
WHEN 2 THEN 'A'
ELSE 'A'
END,
IIF(col1 < 25, 'A', 'A') -- Noncompliant
FROM table1
----
=== Exceptions
2020-06-30 12:48:39 +02:00
2021-01-27 13:42:22 +01:00
This rule does not apply to ``++IF++``/``++CASE++`` chains without ``++ELSE++`` clauses.
2020-06-30 12:48:39 +02:00
2021-02-02 15:02:10 +01:00
2020-06-30 12:48:39 +02:00
----
IF @x < 25 -- no issue, this could have been done on purpose to make the code more readable
PRINT 'A'
ELSE IF @x > 10
PRINT 'A'
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]