rspec/rules/S3981/vbnet/rule.adoc

39 lines
987 B
Plaintext
Raw Normal View History

== Why is this an issue?
2023-05-29 18:37:58 +02:00
The size of a collection and the length of an array are always greater than or equal to zero. Testing it doesn't make sense, since the result is always ``++true++``.
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,vbnet]
2020-06-30 12:48:39 +02:00
----
2023-05-29 18:37:58 +02:00
If Collection.Count >= 0 Then ... 'Noncompliant always true
2020-06-30 12:48:39 +02:00
2023-05-29 18:37:58 +02:00
If array.Length >= 0 Then ... 'Noncompliant always true
2020-06-30 12:48:39 +02:00
----
2023-05-29 18:37:58 +02:00
Similarly testing that it is less than zero will always return ``++false++``.
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,vbnet]
2020-06-30 12:48:39 +02:00
----
2023-05-29 18:37:58 +02:00
If Enumerable.Count < 0 Then ... 'Noncompliant always false
Dim result As Boolean = Array.Length >= 0 'Noncompliant always true
2020-06-30 12:48:39 +02:00
----
2023-05-29 18:37:58 +02:00
Fix the code to properly check for emptiness if it was the intent, or remove the redundant code to keep the current behavior.
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]