rspec/rules/S907/plsql/rule.adoc

62 lines
980 B
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
A ``++GOTO++`` statement is an unstructured change in the control flow. They should be avoided and replaced by structured constructs.
2020-06-30 12:50:59 +02:00
=== Noncompliant code example
2020-06-30 12:50:59 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:50:59 +02:00
----
SET SERVEROUTPUT ON
DECLARE
i PLS_INTEGER := 42;
BEGIN
IF i < 0 THEN
GOTO negative; -- Noncompliant
END IF;
DBMS_OUTPUT.PUT_LINE('positive');
goto cleanup; -- Noncompliant
<<negative>>
DBMS_OUTPUT.PUT_LINE('negative!');
<<cleanup>>
NULL;
END;
/
----
=== Compliant solution
2020-06-30 12:50:59 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:50:59 +02:00
----
SET SERVEROUTPUT ON
DECLARE
i PLS_INTEGER := 42;
BEGIN
IF i < 0 THEN
DBMS_OUTPUT.PUT_LINE('negative!'); -- Compliant
ELSE
DBMS_OUTPUT.PUT_LINE('positive');
END IF;
END;
/
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]