rspec/rules/S3923/python/rule.adoc

56 lines
1.0 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
Having all branches of an `if` chain with the same implementation indicates a problem.
2020-06-30 12:48:39 +02:00
In the following code:
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,python]
2020-06-30 12:48:39 +02:00
----
if b == 0: # Noncompliant
doOneMoreThing()
elif b == 1:
doOneMoreThing()
else:
doOneMoreThing()
b = 4 if a > 12 else 4 # Noncompliant
----
Either there is a copy-paste error that needs fixing or the unnecessary `if` chain needs removing.
=== Exceptions
2020-06-30 12:48:39 +02:00
This rule does not apply to `if` chains without `else`.
2020-06-30 12:48:39 +02:00
2021-02-02 15:02:10 +01:00
[source,python]
2020-06-30 12:48:39 +02:00
----
if b == 0: # no issue, this could have been done on purpose to make the code more readable
doOneMoreThing()
elif b == 1:
doOneMoreThing()
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
=== Highlighting
primary: the top "if" keyword
secondary: each identical body of the "if-elif-else"
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]