2023-05-03 11:06:20 +02:00
== Why is this an issue?
2023-06-12 12:30:49 +02:00
When the line immediately after a conditional has neither an enclosing `BEGIN...END` block nor indentation, the intent of the code is unclear and perhaps not what is executed. Additionally, such code is confusing to maintainers.
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:48:39 +02:00
----
IF @condition -- Noncompliant
EXEC doTheThing;
2023-06-05 10:31:02 +02:00
EXEC doTheOtherThing; -- Was the intent to call this function unconditionally?
2020-06-30 12:48:39 +02:00
----
2023-06-05 10:31:02 +02:00
It becomes even more confusing and bug-prone if lines get commented out.
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:48:39 +02:00
----
2023-06-05 10:31:02 +02:00
IF @condition -- Noncompliant
-- EXEC doTheThing;
EXEC doTheOtherThing; -- Was the intent to call this function conditionally?
2020-06-30 12:48:39 +02:00
----
2023-06-05 10:31:02 +02:00
2023-06-12 12:30:49 +02:00
Indentation alone or together with `BEGIN...END` block makes the intent clear.
2020-06-30 14:49:38 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:48:39 +02:00
----
IF @condition
EXEC doTheThing;
2023-06-05 10:31:02 +02:00
EXEC doTheOtherThing; -- Clear intent to call this function unconditionally
2020-06-30 12:48:39 +02:00
2023-06-05 10:31:02 +02:00
IF @condition
BEGIN
EXEC doTheThing;
END;
EXEC doTheOtherThing; -- Clear intent to call this function unconditionally
2020-06-30 12:48:39 +02:00
----
2021-06-02 20:44:38 +02:00
2023-06-12 12:30:49 +02:00
This rule raises an issue if the line controlled by a conditional has the same indentation as the conditional and is not enclosed in a `BEGIN...END` block.
2023-06-05 10:31:02 +02:00
2021-06-03 09:05:38 +02:00
ifdef::env-github,rspecator-view[]
2021-09-20 15:38:42 +02:00
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
2021-06-08 15:52:13 +02:00
'''
2021-06-02 20:44:38 +02:00
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
2023-06-22 10:38:01 +02:00
2021-06-03 09:05:38 +02:00
endif::env-github,rspecator-view[]