rspec/rules/S3984/python/rule.adoc

49 lines
1.0 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Creating a new ``++Exception++`` without actually raising it has no effect and is probably due to a mistake.
2020-06-30 12:48:39 +02:00
=== Noncompliant code example
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,python]
2020-06-30 12:48:39 +02:00
----
def func(x):
if not isinstance(x, int):
TypeError("Wrong type for parameter 'x'. func expects an integer") # Noncompliant
if x < 0:
ValueError # Noncompliant
return x + 42
----
=== Compliant solution
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,python]
2020-06-30 12:48:39 +02:00
----
def func(x):
if not isinstance(x, int):
raise TypeError("Wrong type for parameter 'x'. func expects an integer")
if x < 0:
raise ValueError
return x + 42
----
== Resources
2020-06-30 12:48:39 +02:00
* https://docs.python.org/3/tutorial/errors.html#raising-exceptions[Python documentation - Raising Exceptions]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Raise this exception or remove this useless statement
=== Highlighting
Primary: The statement creating an Exception.
endif::env-github,rspecator-view[]