rspec/rules/S1141/cfamily/rule.adoc

62 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Nesting ``++try++``/``++catch++`` or ``++@try++``/``++@catch++`` blocks severely impacts the readability of source code because it makes it too difficult to understand which block will catch which exception.
2020-06-30 12:47:33 +02:00
2021-02-02 15:02:10 +01:00
2021-01-26 14:30:57 +01:00
This {cpp} example also applies to Objective-C.
2020-06-30 12:47:33 +02:00
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,cpp]
2020-06-30 12:47:33 +02:00
----
try {
try { // Noncompliant
doSomething();
} catch (RuntimeException e) {
/* Ignore */
}
doSomethingElse();
} catch (Exception e) {
/* ... */
}
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,cpp]
2020-06-30 12:47:33 +02:00
----
try {
dedicatedMethod(); // Compliant
doSomethingElse();
} catch (Exception e) {
/* ... */
}
/* ... */
private void dedicatedMethod() {
try { // Compliant
doSomething();
} catch (RuntimeException e) {
/* Ignore */
}
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]